Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add bucket albedo map experiments #482

Merged
merged 2 commits into from
Feb 16, 2024
Merged

add bucket albedo map experiments #482

merged 2 commits into from
Feb 16, 2024

Conversation

juliasloan25
Copy link
Member

@juliasloan25 juliasloan25 commented Feb 6, 2024

Purpose

Add global bucket experiments using albedo as a static map and as a temporal map. Run these on CPU and GPU in CI pipeline. This will test if our current static and temporal albedo types can be used globally on GPU.

These runs are copied almost directly from the functional albedo global bucket run, but the albedo types are changed, and the simulation runtime is increased in the temporal map case to exercise the code path used when reading in the next data from a file.

follows #469
closes #477

Content

  • add 2 new experiments: global bucket with static map albedo, global bucket with temporal map albedo
  • add experiments to buildkite pipeline on CPU and GPU
  • modify Regridder so we can use same input file with different float types in different runs
  • add new temporal albedo dataset with NaN converted to 1, update artifact path
  • use NCDatasets' nomissing function to convert Union{Missing, FT} type to FT when reading from input datasets
    • fixes ERROR: cannot convert MissingtoFloat64` which occasionally pops up on buildkite

  • I have read and checked the items on the review checklist.

@juliasloan25 juliasloan25 force-pushed the js/global-bucket branch 3 times, most recently from 6eff7bb to a4d1ba0 Compare February 6, 2024 02:48
@juliasloan25 juliasloan25 requested review from kmdeck and removed request for kmdeck February 6, 2024 17:50
@juliasloan25 juliasloan25 force-pushed the js/global-bucket branch 4 times, most recently from f8d3bce to f54ca0b Compare February 15, 2024 20:22
@juliasloan25 juliasloan25 force-pushed the js/global-bucket branch 4 times, most recently from 9849b9e to da21cc7 Compare February 16, 2024 00:37
Copy link
Member

@kmdeck kmdeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Julia! The plot for the temporal albedo looks pretty wacky. The mean surface fluxes are very large and positive. I think it is because the high latitudes have an albedo of 1, which reflects all shortwave radiation back, and this affects the mean.

I think over time we will move away from the temporal map (because it makes more sense to compute the albedo consistently using our snow model+bareground albedo), so im not too worried about it. But otherwise we need to find a better map without the missing data.

You added a nomissing function. Does this replace the values? or does the simulation run with missing values?

@juliasloan25
Copy link
Member Author

You added a nomissing function. Does this replace the values? or does the simulation run with missing values?

By default, data read in from a NetCDF file using NCDatasets will have type Union{Missing, DataType} (where DataType here for us is Float64). There are no missing values in the data, so NCDatasets.nomissing just converts all the types to DataType. If there were a missing value, it would give an error message and exit the simulation. I'm not sure why this is coming up now and didn't come up before

@juliasloan25 juliasloan25 merged commit 66c293f into main Feb 16, 2024
8 checks passed
@juliasloan25 juliasloan25 deleted the js/global-bucket branch February 16, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add global bucket runs with albedo maps
2 participants